feat: make ServiceMonitor API group configurable#2574
Open
amarkdotdev wants to merge 1 commit into
Open
Conversation
amarkdotdev
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
amarkdotdev
force-pushed
the
feat/servicemonitor-api-group
branch
2 times, most recently
from
faeeef5 to
86e20fc
Compare
Add apiGroup to ServiceMonitorConfig so clusters using Azure Managed Prometheus on AKS can target azmonitoring.coreos.com. Defaults to monitoring.coreos.com and updates RBAC for the alternate API group. Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
amarkdotdev
force-pushed
the
feat/servicemonitor-api-group
branch
from
86e20fc to
bd526cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2397.
Azure Managed Prometheus on AKS registers ServiceMonitor under
azmonitoring.coreos.cominstead ofmonitoring.coreos.com. This change adds an optionalapiGroupfield toServiceMonitorConfig(defaulting tomonitoring.coreos.com) and uses it when looking up the ServiceMonitor CRD and creating/updating ServiceMonitor objects.Changes
apiGrouptoServiceMonitorConfigwithGetAPIGroup()helper and documented defaultsconfig/rbac/role.yaml) forazmonitoring.coreos.com/servicemonitorsvalues.yamlTesting
go test ./controllers/... -run TestServiceMonitor