fix(dpuagent): probe firmware reset requirements in boot-ID reboot path#59
Open
tsorya wants to merge 1 commit into
Open
fix(dpuagent): probe firmware reset requirements in boot-ID reboot path#59tsorya wants to merge 1 commit into
tsorya wants to merge 1 commit into
Conversation
When RebootMethodDiscovery is false (boot-ID path), getRebootMethodBootID always returned SystemLevelReset on first boot. This triggers shutdown -h on the DPU, which halts Linux but does not power off the ARM SoC. If a firmware update (ATF/UEFI) happened during boot, the ARM enters a protected state where mlxfwreset fails (error 274), leaving the DPU in a zombie state that only a host power cycle can fix. Add probeResetRequirements() which runs a best-effort mlxfwreset status check on each MST device before defaulting to SystemLevelReset. If any device reports reset_needed with a power-cycle signal, return PowerCycle instead. On any probe failure (no MFT, no MST devices, parse error), fall back to SystemLevelReset preserving existing behavior. Extract queryDeviceResetStatus() as a shared helper used by both probeResetRequirements and getRebootMethodDeviceQuery to avoid duplicating the mlxfwreset invocation and JSON parsing logic. Signed-off-by: Igal Tsoiref <itsoiref@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When RebootMethodDiscovery is false (boot-ID path), getRebootMethodBootID always returned SystemLevelReset on first boot. This triggers shutdown -h on the DPU, which halts Linux but does not power off the ARM SoC. If a firmware update (ATF/UEFI) happened during boot, the ARM enters a protected state where mlxfwreset fails (error 274), leaving the DPU in a zombie state that only a host power cycle can fix.
Add probeResetRequirements() which runs a best-effort mlxfwreset status check on each MST device before defaulting to SystemLevelReset. If any device reports reset_needed with a power-cycle signal, return PowerCycle instead. On any probe failure (no MFT, no MST devices, parse error), fall back to SystemLevelReset preserving existing behavior.
Extract queryDeviceResetStatus() as a shared helper used by both probeResetRequirements and getRebootMethodDeviceQuery to avoid duplicating the mlxfwreset invocation and JSON parsing logic.