fix(hostagent): skip redundant network request file write on reconcile#57
Draft
tsorya wants to merge 1 commit into
Draft
fix(hostagent): skip redundant network request file write on reconcile#57tsorya wants to merge 1 commit into
tsorya wants to merge 1 commit into
Conversation
The AddVFToBridge operation unconditionally rewrote the network request file every 30-second reconcile tick, even when the VF name had not changed. Guard the write behind a comparison so the file is only updated when the VF interface name actually differs. Signed-off-by: Igal Tsoiref <itsoiref@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddVFToBridgeoperation in the hostagent network manager unconditionally rewrote the network request file every 30-second reconcile tick, even when the VF name had not changed.wrote network request filelog lines.Test plan
wrote network request filelog only appears on first reconcile (or when VF name changes), not every 30 seconds.