Skip to content

[cudf] Require explicit stream and MR for test make_null_mask - #23639

Draft
nirandaperera wants to merge 1 commit into
NVIDIA:pull-request/23581from
nirandaperera:test-make-null-mask-mr
Draft

[cudf] Require explicit stream and MR for test make_null_mask#23639
nirandaperera wants to merge 1 commit into
NVIDIA:pull-request/23581from
nirandaperera:test-make-null-mask-mr

Conversation

@nirandaperera

@nirandaperera nirandaperera commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

This is a low-priority change, and would likely be automatically addressed when #20780 completes.

Depends on #23581

A part of #20780.

cudf::test::detail::make_null_mask still defaulted to the test stream and current device resource, which hid unintentional resource use. This removes those defaults and updates callers to pass stream and memory resources explicitly.

  • Drop default stream/mr parameters from detail::make_null_mask
  • Pass fixture-scoped stream/mr at direct test call sites, including nested lambdas that now capture them
  • Keep shared IO/test helpers signature-stable for now by binding local cudf::get_default_stream() / cudf::get_current_device_resource_ref() inside the helpers until those modules are migrated

NOTE:
In many instances, the default stream and current MR are now defined in test fixture scopes. Ideally when each module is ported to memory_resources, corresponding test cases and utils should follow suite.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: niranda perera <niranda.perera@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 12, 2026
@nirandaperera nirandaperera added improvement Improvement / enhancement to an existing function breaking Breaking change labels Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant