Generate pylibcudf stubs with stubgen-pyx - #23628
Draft
vyasr wants to merge 1 commit into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pyifiles withstubgen-pyx==0.2.18Motivation
We have been improving
stubgen-pyxupstream, and this draft gives cudf developers a concrete diff for evaluating whether generated pylibcudf stubs are close enough to replace the handwritten files.Notes for reviewers
This is intentionally a draft/evaluation PR. The generated stubs are much more complete and source-derived than the handwritten versions, but there are still visible gaps worth reviewing:
CudaStreamLikeis lost in generated signatures, generally becomingobject | NoneValidation
python/pylibcudf/pylibcudf/**/*.pyifiles and regenerated them withpre-commit run stubgen-pyx-pylibcudf --all-filespre-commit run stubgen-pyx-pylibcudf --all-filesafter rebasing on latestupstream/main; it passed with no further changespre-commit run ruff --files ci/checks/generate_pylibcudf_stubs.py .pre-commit-config.yamlpre-commit run ruff-format --files ci/checks/generate_pylibcudf_stubs.py .pre-commit-config.yamlpre-commit run yamllint --files .pre-commit-config.yamlpre-commit run verify-copyright --files ...git diff --checkFull commit-time
mypywas also run while preparing this branch and currently fails on the generated stubs; that failure is part of the review signal for this draft.