Fix small bug in nvml.unit_get_devices()#2278
Merged
Merged
Conversation
mdboom
added
bug
This comment has been minimized.
This comment has been minimized.
leofang
approved these changes
Jun 30, 2026
Member
|
Well... I clicked merge on the cybind MR 🤷 Since the Window CI failures are known (due to the new CUPTI release which #2276 fixed), let me just admin-merge (and try to backport). |
leofang
added
the
to-be-backported
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-2278-to-12.9.x origin/12.9.x
cd .worktree/backport-2278-to-12.9.x
git switch --create backport-2278-to-12.9.x
git cherry-pick -x 77f2757c9426ae11f36192e1b385ac194f35a4b6 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small bug in the hand-written wrappers for NVML, that was discovered while rebuilding
cuda.bindings.nvmlby including the upstream header while investigating #1663. (A nice side-effect of that is that it finds real bugs!).Unfortunately, I don't know if this test can/will run on any of our hardware.