Fully clean up buffers/memory resources in tests#2243
Merged
Conversation
Add explicit sync points and notes around `mr.close()` making sure that there is no MR shutdown with pending async buffer freeing. These can currently cause occasional dead-locks when we have many MRs in parallel. Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
seberg
added
P1
Contributor
Contributor
|
Somewhat adjacent issue: #1719 |
mdboom
approved these changes
Jun 23, 2026
mdboom
left a comment
mdboom
left a comment
Contributor
There was a problem hiding this comment.
I see no reason not to merge this.
As an aside, though... How did you find all of these and is there a way to enforce that this kind of thing doesn't creep back in in the future?
Contributor
Author
That'll be the full changes at #2194 to run with pytest-run-parallel, I was just splitting things out since it seemed a bit easier to move forward. To be fair, cleanup eventually happens so with single threaded (no pytest-run-parallel) I am not sure this can fail (at least in practice). /ok to test b478199 |
Contributor
Author
|
/ok to test b478199 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe the final (small) split-out for the free-threading test PR.
Add explicit sync points and notes around
mr.close()making sure that there is no MR shutdown with pending async buffer freeing. These can currently cause occasional dead-locks when we have many MRs in parallel. I believe this is a small upstream issue (625181).