Run the XPOIS, xFit and XScan device pipeline through Dragon - #43
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/cuPhoton/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds a persistent Dragon-based XScan device pipeline. It validates inputs and results, reuses device contexts across shard items, audits published summaries, and documents direct and Dragon execution. ChangesXScan device pipeline
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This change adds a validated, persistent Dragon pipeline for XPOIS, xFit and XScan jobs, along with tests and documentation. No concrete defect remains open against the current revision. The author reports that live multi-GPU Dragon runs are still unverified, so owners should confirm a real run, but nothing identified blocks the merge. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
f861bed to
e6dfba1
Compare
2d9dc4f to
99f5ddc
Compare
99f5ddc to
d440c19
Compare
e6dfba1 to
9e71f82
Compare
|
@coderabbitai full review |
✅ Action performedFull review finished. |
d440c19 to
f009ace
Compare
9e71f82 to
a5b6002
Compare
f009ace to
ee6c686
Compare
745fe81 to
5f5f45f
Compare
ee6c686 to
2c30ede
Compare
melo-gonzo
left a comment
There was a problem hiding this comment.
Approving: the PR tree is byte-identical to the open GitLab branch for every file it touches, and my earlier findings remain as posted. Merge after the internal MR is merged so the histories match.
5f5f45f to
305a333
Compare
2c30ede to
800e3d5
Compare
305a333 to
6eb72a5
Compare
a49391a to
fbb50d9
Compare
36f3e8e to
d9bb505
Compare
2579bce to
3646c0a
Compare
|
@coderabbitai full review |
✅ Action performedFull review finished. |
bc5fe97 to
e0589c6
Compare
97e0135 to
fb53953
Compare
Reuse one placed device context across complete image-pair jobs. Bind compact launch and result descriptors to input, configuration, and scientific evidence identities, and retain Torch-before-CuPy startup. Document direct execution and Dragon worker reuse with the required checkpoint and feature-schema contracts. Signed-off-by: Trent Nelson <trentn@nvidia.com>
Treat JSON integers outside floating range as invalid runtime metadata. This lets the coordinator persist a failed terminal summary when a worker's context-load duration cannot be represented as a finite number. Signed-off-by: Trent Nelson <trentn@nvidia.com>
e0589c6 to
7439af0
Compare
fb53953 to
6348319
Compare
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Run complete XPOIS, xFit, and XScan image-pair jobs in persistent Dragon workers, reusing one device context per worker. Compact launch and result descriptors bind each result to its inputs, configuration, and scientific evidence while preserving Torch-before-CuPy startup.
Live Dragon and GPU execution remain unverified for this revision.