docs: fix stale dataloader-state callback references in custom_datase…#40
Open
foreverlms wants to merge 1 commit into
Open
docs: fix stale dataloader-state callback references in custom_datase…#40foreverlms wants to merge 1 commit into
foreverlms wants to merge 1 commit into
Conversation
…t.md The "Checkpoint / resume" section referenced the legacy DataLoaderStateCallback with distributor_type="cosmos_dataloader", but that class only activates for distributor_type="no_replace" (_ACTIVE_DISTRIBUTOR_TYPES), so the documented snippet is a silent no-op for cosmos_dataloader resume. It also referenced a non-existent JointDataLoaderStateCallback with a distributor_type kwarg its real counterpart does not accept. Point the doc at the actual classes wired by the live recipes (llava_ov_vlm.py): CosmosDataLoaderStateCallback() and JointCosmosDataLoaderStateCallback(outer_loader=...), both from cosmos_framework.callbacks.cosmos_dataloader_state. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Dinghow
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update document for custom dataset.