Sync with internal with new mapping design#29
Open
yy-code-nv wants to merge 6 commits into
Open
Conversation
yy-code-nv
commented
Jun 9, 2026
yy-code-nv
commented
Collaborator
- regression past
- inference correct
yy-code-nv
force-pushed
the
yangyangt/try_sync_with_internal
branch
from
90e7ca9 to
21230f9
Compare
Pipeline run via packages/cosmos-framework-release/release.sh:
- 220+ files changed/added/removed across guardrails, callbacks, configs,
data, model, tools, utils to match current i4 source.
- local_datasets/ restored to match cosmos-framework main exactly; the dir
is now CF-owned (excluded from the mapping going forward).
- Removed 4 orphan files re-introduced on this branch (multiview_dataloader,
vlm/defaults/dataloader, nvlm_data_unify, nvlm_sample_loaders_and_part_filters)
-- already excluded in mapping_config.toml; nothing in CF imports them.
- New modules brought in: data/imaginaire/webdataset/augmentors/image,
data/vfm/action/action_processing, data/vfm/vlm/video_decoder_qwen,
data/vlm/processors/{nemotron3densevl,nemotronvl}, model/tokenizer/evaluation,
model/vfm/mot/cosmos3_vfm_qwen3_vl_network_test, utils/vfm/video_preprocess,
others.
- Internal http(s) URLs scrubbed to https://invalid_url (s3://, github,
pytorch, docs.nvidia, arxiv, etc. preserved). NFS/usr leak paths scrubbed
to /invalid_dir. SPDX/OpenMDW-1.1 headers applied.
- COSMOS_INTERNAL flag now defaults to False (was inheriting TRAINING=True).
- Zero dangling cosmos_framework module imports.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…erministic to False - utils/vfm/monkey_patch.py: rename _EXPECTED_TRANSFORMERS_VERSION -> _EXPECTED_TRANSFORMERS_VERSION_PREFIX (matches its "4.57." prefix-match semantics; the constant is a prefix, not an exact version). - configs/base/vlm/defaults/policy_config.py: VLMModelConfig.deterministic default flipped True -> False. The comment already notes deterministic Flash-Attention kernels are slower and only needed for parity bit-exactness, so opt-in is the better default. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yy-code-nv
force-pushed
the
yangyangt/try_sync_with_internal
branch
from
21230f9 to
fcc90a3
Compare
- Stop migrating tests that pull in unshipped fixtures/helpers (configs/base/base_config_test.py, model/vfm/mot/cosmos3_vfm_qwen3_vl_network_test.py, model/vfm/vlm/nemotron_3_dense_vl/nemotron_3_dense_vl_test.py). Excluded in mapping_config.toml and removed from CF. - inference/action.py: hand-sync from imaginaire4/packages/cosmos3/cosmos3/ action.py. Adds ActionProcessingRecord / make_batched_action_processing_fields paths and moves pad_action_to_max_dim to the action_processing import group. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ActionPromptJsonFormatter can return a dict for the caption_key; downstream consumers expect a string, so json.dumps it when needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Some issue might need pay attention?
|
- Loosened REPLACE-NEXT semantics in the rewriter pick up the next *matching* line; lets a directive placed above a docstring scrub URLs inside it. Applied to avae.py and utils/misc.py to scrub two internal gitlab-master.nvidia.com URLs that previously survived in module/class docstrings. - cluster.py and unittest.py removed from cosmos_framework/configs/base/defaults/ and excluded from the release mapping (CF-owned going forward). - Other small updates picked up from current i4 source. No dangling imports. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The /cluster default group no longer exists (cluster.py was dropped and the cluster entry removed from configs/base/config.py's defaults list). Hydra errors with ConfigCompositionException when an experiment tries to override a missing group, so strip the override from the three remaining experiments: vision_sft_nano, vision_sft_super, action_policy_droid_nano. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.