Skip to content

[LLM] Custom models - #1001

Draft
podkidyshev wants to merge 2 commits into
mainfrom
ipod/llm-custom-model
Draft

[LLM] Custom models#1001
podkidyshev wants to merge 2 commits into
mainfrom
ipod/llm-custom-model

Conversation

@podkidyshev

Copy link
Copy Markdown
Contributor

Summary

Allow custom models for vLLM and SGLang

Test Plan

  • Automated CI
  • Manual runs

Additional Notes

@podkidyshev podkidyshev self-assigned this Aug 14, 2026
@podkidyshev podkidyshev added the enhancement improvements/extension to an existing feature label Aug 14, 2026
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: dd6e04db-a070-4ec9-a188-af0d8baad123

📥 Commits

Reviewing files that changed from the base of the PR and between 9f1c117 and 7362f9b.

📒 Files selected for processing (5)
  • doc/workloads/sglang.rst
  • doc/workloads/vllm.rst
  • src/cloudai/workloads/common/llm_serving.py
  • tests/workloads/sglang/test_workload.py
  • tests/workloads/vllm/test_workload.py

📝 Walkthrough

Walkthrough

The change adds local model support for SGLang and vLLM. Absolute model paths no longer create Hugging Face installables. Tests cover this behavior, and workload documentation describes required mounts and model files.

Changes

Local model loading

Layer / File(s) Summary
Absolute-path installable selection
src/cloudai/workloads/common/llm_serving.py, tests/workloads/sglang/test_workload.py, tests/workloads/vllm/test_workload.py
installables omits hf_model when cmd_args.model is an absolute path. SGLang and vLLM tests verify the resulting installables.
Local model configuration documentation
doc/workloads/sglang.rst, doc/workloads/vllm.rst
The documentation explains container mounts, local model paths, configuration examples, and required model files.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7362f

This change adds custom-model support for vLLM and SGLang with accompanying documentation and tests; no actionable merge-blocking risk remains.

Suggested reviewers: jj10306

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: support for custom models in LLM workloads.
Description check ✅ Passed The description directly states that the pull request adds custom model support for vLLM and SGLang.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ipod/llm-custom-model

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement improvements/extension to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant