[on hold] Drop tests for thrust::pair and thrust::tuple - #6637
Closed
bernhardmgruber wants to merge 1 commit into
Closed
[on hold] Drop tests for thrust::pair and thrust::tuple#6637bernhardmgruber wants to merge 1 commit into
thrust::pair and thrust::tuple#6637bernhardmgruber wants to merge 1 commit into
Conversation
Those are alias to cuda::std anyway, which is tested already
This comment has been minimized.
This comment has been minimized.
davebayer
approved these changes
Nov 17, 2025
Contributor
🥳 CI Workflow Results🟩 Finished in 10h 02m: Pass: 100%/70 | Total: 8h 48m | Max: 44m 43s | Hits: 99%/115217See results here. |
miscco
requested changes
Nov 17, 2025
miscco
left a comment
miscco
left a comment
Contributor
There was a problem hiding this comment.
I would like to keep them for as long as we have thrust::pair and thrust::tuple in the library
bernhardmgruber
changed the title
thrust::pair and thrust::tuplethrust::pair and thrust::tuple
bernhardmgruber
marked this pull request as draft
November 17, 2025 08:32
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are alias to
cuda::stdanyway, which is tested already@miscco please let me know if you would like to move any Thrust tests to libcu++.