Refactor Thrust generic system headers - #6426
Closed
bernhardmgruber wants to merge 7 commits into
Closed
Conversation
Contributor
😬 CI Workflow Results🟥 Finished in 2h 15m: Pass: 25%/70 | Total: 18h 49m | Max: 2h 11m | Hits: 65%/13960See results here. |
Contributor
Author
|
Alright, a big problem here is that many generic thrust algorithm implementation headers include themselves again transitively. So the current split in header+forward declaration and inc file+lots of includes+implementation avoids the problem by declaring the generic implementation early enough. |
bernhardmgruber
marked this pull request as draft
January 29, 2026 17:33
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
I will replace this PR with a different approach. |
Contributor
Author
|
I'll leave this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*.inlfile content to their headers