Skip to content

Automatic SASS diffs for PRs - #10780

Open
Jacobfaib wants to merge 11 commits into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-08-12/branch-sass-checks
Open

Automatic SASS diffs for PRs#10780
Jacobfaib wants to merge 11 commits into
NVIDIA:mainfrom
Jacobfaib:jacobf/2026-08-12/branch-sass-checks

Conversation

@Jacobfaib

@Jacobfaib Jacobfaib commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

closes #10726

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-project-automation github-project-automation Bot moved this to Todo in CCCL Aug 12, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Progress in CCCL Aug 12, 2026
@Jacobfaib

Jacobfaib commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🔬 CUB benchmark SASS comparison

⚠️ The SASS comparison did not produce a report. See the job log.

This check never blocks a merge.

Artifacts

@github-actions

This comment has been minimized.

Sign in to view
@Jacobfaib

Jacobfaib commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

1 similar comment
@Jacobfaib

Jacobfaib commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Jacobfaib

Jacobfaib commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Jacobfaib

Jacobfaib commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

1 similar comment
@Jacobfaib

Jacobfaib commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Jacobfaib

Jacobfaib commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Jacobfaib

Jacobfaib commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Jacobfaib

Jacobfaib commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Jacobfaib

Jacobfaib commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Jacobfaib
Jacobfaib requested a review from wmaxey August 14, 2026 18:02
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
griwes
griwes approved these changes Aug 14, 2026
View reviewed changes

@griwes griwes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed throughout. Looks good. The normalization catches the usual causes of noise in the SASS diffs, from what I can tell. Tests appear appropriate.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
bernhardmgruber
bernhardmgruber reviewed Aug 16, 2026
View reviewed changes
Comment thread ci/matrix.yaml
gevtushenko
gevtushenko requested changes Aug 16, 2026
View reviewed changes
Comment thread CMakePresets.json
"name": "cub-benchmark",
"displayName": "CUB benchmarking",
"generator": "Ninja",
"binaryDir": "${sourceDir}/build/$env{CCCL_BUILD_INFIX}/${presetName}",

@gevtushenko gevtushenko Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

important: there's a couple of places that you'd have to change before we can merge this. First, docs/cub/benchmarking.rst and docs/cub/tuning_infra.rst showcase building in build/, which is fine, but later illustrate build/bin/cub.bench* paths that do not include the preset directory. Besides that, benchmarks/scripts/submit_benchmark_job.sh builds in build_perf instead of build/, so can get broken after this is merged, please adjust. Most importantly, some (soon to be deleted) internal tuning scripts create a build directory per GPU, which will conflict with one executable path introduced here. Work with @gonidelis to make sure all tuning and benchmarking scripts work with the change.

@Jacobfaib Jacobfaib Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs and benchmarking scripts should be fixed now.

@github-project-automation github-project-automation Bot moved this from In Review to In Progress in CCCL Aug 16, 2026
gevtushenko
gevtushenko reviewed Aug 17, 2026
View reviewed changes
Comment thread ci/sass/compare_sass.py
@Jacobfaib
Jacobfaib requested a review from a team as a code owner August 17, 2026 13:10
@Jacobfaib
Jacobfaib force-pushed the jacobf/2026-08-12/branch-sass-checks branch from 8c3b2ee to 5af0941 Compare August 17, 2026 13:10
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

⏱️ CCCL compile-time benchmark comparison: Public headers compile-time bench

Result: 0 regression row(s), 2 improvement row(s) above threshold.

Run Value
Config public-headers-gcc13
Baseline origin/main
Preset all-dev
Targets cub.headers.base, thrust.cpp.cuda.headers.base, libcudacxx.test.public_headers
GPU / launch args rtx2080 / --cuda 13.3 --host gcc13

Artifacts: reports and traces

Direct file processing

-f file-processing exclusive --sort total

🟢 Direct file processing — Improvements
Rank Improvement impact Selected Δ Baseline Current Event Matched traces
1 0.613404 -0.613404 5.379730 4.766326 Processing Header File: libcudacxx/include/cuda/std/__cccl/prologue.h 552
2 0.216007 -0.216007 1.668724 1.452717 Processing Header File: libcudacxx/include/cuda/std/__cccl/epilogue.h 552

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 4h 28m: Pass: 100%/531 | Total: 8d 12h | Max: 2h 16m | Hits: 58%/1117894

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@griwes griwes griwes approved these changes
@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-codeowners
@jrhemstad jrhemstad Awaiting requested review from jrhemstad
@wmaxey wmaxey Awaiting requested review from wmaxey
@gevtushenko gevtushenko Awaiting requested review from gevtushenko
@bernhardmgruber bernhardmgruber Awaiting requested review from bernhardmgruber

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

CCCL
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[INFRA]: Automated CUB benchmark SASS-diff checks on every PR

4 participants

@Jacobfaib @griwes @bernhardmgruber @gevtushenko