Skip to content

fix: address non-blocking reviewer nits from #140, #141, #143#172

Open
mimran-khan wants to merge 1 commit into
NVIDIA:mainfrom
mimran-khan:fix/reviewer-nits-followup
Open

fix: address non-blocking reviewer nits from #140, #141, #143#172
mimran-khan wants to merge 1 commit into
NVIDIA:mainfrom
mimran-khan:fix/reviewer-nits-followup

Conversation

@mimran-khan

Copy link
Copy Markdown
Contributor

Summary

Bundles non-blocking reviewer nits from three merged PRs into a single follow-up:

Testing

  • test_extensionless_file_not_hard_dropped_by_code_example — confirms an extensionless file with code-example context is downweighted, not dropped.
  • test_none_severity_treated_as_low — confirms severity=None doesn't crash and is treated as LOW.
  • test_none_severity_below_threshold_dropped — confirms None severity at low confidence is dropped (no severity floor protection).
  • All existing tests pass (43 in the affected test files).

Not addressed in this PR

…VIDIA#143

- Remove "other" from _NON_EXECUTABLE_FILE_TYPES so extensionless
  scripts (inferred as "other") get code-example findings downweighted
  instead of hard-dropped (NVIDIA#140 nit)
- Guard f.severity.upper() with None fallback in _fallback_filtered
  to match the codebase convention of (f.severity or "LOW").upper() (NVIDIA#143 nit)
- Clarify --recursive help text to say "immediate subdirectories"
  instead of implying full recursive tree walk (NVIDIA#141 nit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant