fix: address non-blocking reviewer nits from #140, #141, #143#172
Open
mimran-khan wants to merge 1 commit into
Open
fix: address non-blocking reviewer nits from #140, #141, #143#172mimran-khan wants to merge 1 commit into
mimran-khan wants to merge 1 commit into
Conversation
…VIDIA#143 - Remove "other" from _NON_EXECUTABLE_FILE_TYPES so extensionless scripts (inferred as "other") get code-example findings downweighted instead of hard-dropped (NVIDIA#140 nit) - Guard f.severity.upper() with None fallback in _fallback_filtered to match the codebase convention of (f.severity or "LOW").upper() (NVIDIA#143 nit) - Clarify --recursive help text to say "immediate subdirectories" instead of implying full recursive tree walk (NVIDIA#141 nit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles non-blocking reviewer nits from three merged PRs into a single follow-up:
_NON_EXECUTABLE_FILE_TYPES): Remove"other"from the non-executable set so extensionless scripts (e.g.cleanup_scriptwith no.shextension, inferred as"other"by_infer_file_type) get code-example findings downweighted instead of hard-dropped. This closes the edge case @rng1995 flagged where an unknown-but-executable extension could re-open the code-example bypass._fallback_filteredseverity guard): Guardf.severity.upper()with(f.severity or "LOW").upper()to match the codebase convention (e.g._compute_risk_score). PreventsAttributeErrorif a finding hasseverity=None.--recursivehelp text): Reword to say "immediate subdirectories" instead of "directories containing multiple skills" — clarifies that--recursivescans one level deep, not a full recursive tree walk.Testing
test_extensionless_file_not_hard_dropped_by_code_example— confirms an extensionless file with code-example context is downweighted, not dropped.test_none_severity_treated_as_low— confirmsseverity=Nonedoesn't crash and is treated as LOW.test_none_severity_below_threshold_dropped— confirms None severity at low confidence is dropped (no severity floor protection).Not addressed in this PR
filtering_modemetadata on LLM-runtime-failure path: requires adding a state field + TypedDict change across 3 files — deferred as metadata-accuracy improvement..svgin_BINARY_EXTENSIONS: code isn't onmainyet (fix(static-runner): skip binary/PDF files and filter PE3 .env doc references #157 still open). Will be addressed on the fix(static-runner): skip binary/PDF files and filter PE3 .env doc references #157 branch or after merge.finally: pass, per-skill cleanup path, typing, summary count):finally: passalready removed; others are minor style items.