Merge updates from upstream and integrate local security report optimizations#163
Open
hbui290 wants to merge 8 commits into
Open
Merge updates from upstream and integrate local security report optimizations#163hbui290 wants to merge 8 commits into
hbui290 wants to merge 8 commits into
Conversation
added 8 commits
June 22, 2026 10:21
… pre-filtering, and bug fixes
… of substring match
… in optimization test
This was referenced Jun 23, 2026
rng1995
requested changes
Jun 23, 2026
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: Request changes (strong) — a 19-file upstream-merge grab-bag with some genuinely good ideas (SQLite cache, block-aware chunking, retry/backoff), but several blocking problems including a fail-open detection regression.
Blocking
- Detection-coverage regression (fail-open).
_SKIP_DIRSinsrc/skillspector/nodes/build_context.pyis expanded to includedocs,doc,tests,test,spec,specs,build,dist,out,target,images,media,brand(~L775-808), now matched against the relative path (~L884). A malicious skill can hide a payload in e.g.tests/ordocs/and evade scanning entirely. For a security scanner this is a serious regression — these must not be skipped by default. (The bundledBAO_CAO_TOI_UU_HOA.mdeven frames this as fixing a "file omission" bug, but the net effect is more directories silently skipped.) - Committed personal/local artifacts.
BAO_CAO_TOI_UU_HOA.mdandHUONG_DAN_SU_DUNG.mdare non-project docs containing dev-machine absolute paths (file:///Users/winston/.gemini/antigravity-ide/scratch/SkillSpector/...). These should not land in the repo. load_dotenv()at package import insrc/skillspector/__init__.py(~L135-136): an import-time side effect that auto-loads.envfrom CWD. Risky for a tool run against untrusted skill directories — it could ingest a scanned skill's.env. Move it behind the CLI entrypoint, not package import.- Production code detecting test mocks.
LLMAnalyzerBase._original_run_batches = LLMAnalyzerBase.run_batches(llm_analyzer_base.py~L673) plus theis_patchedmock-introspection branch insemantic_security_discovery.py(~L730-756) couple prod behavior to the test harness — a code smell that can mask real regressions. - Scope / conflicts. Bundles unrelated changes and overlaps/conflicts with #157 (binary skip), #159/#164/#116 (zip-slip/ingest,
_download_file/_extract_zip), and #142/#153/#122 (_compute_risk_score/ scoring +report.py). Please split into focused PRs and rebase.
The good ideas (persistent SQLite cache, smarter chunk_file_by_lines, deterministic finding ordering, retry/backoff) are worth landing — just on their own focused PRs and without the _SKIP_DIRS expansion, the committed local docs, and the import-time load_dotenv().
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request merges the upstream changes from NVIDIA/SkillSpector into the codebase and integrates custom enhancements:
All 725+ tests pass successfully.