Repository navigation
fix(server): defer reconciliation during sandbox lifecycle operations - #4983
Open
TaylorMutch wants to merge 1 commit into
Open
TaylorMutch wants to merge 1 commit into
TaylorMutch wants to merge 1 commit into
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Label |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent reconciliation from failing a sandbox restart with the previous runtime's
ContainerExitedobservation. Release Dev's Docker SSH identity test exposed this race when a sweep observed the stopped container after the gateway had already committedStarting.Related Issue
Closes #4981
Changes
Release Notes
Testing
2c31ac7e606c4e175288cee3656b23192a1a36b0, using a freshly built workload fixture. A temporary wrapper routes containers throughhost.docker.internalfor Docker Desktop; repository test code is unchanged.Checklist