Skip to content

feat(helm): add server.extraEnv for the gateway container - #4876

Merged
krishicks merged 1 commit into
NVIDIA:mainfrom
ericcurtin:feat/4553-helm-gateway-extra-env/ericcurtin
Oct 23, 2026
Merged

krishicks merged 1 commit into
NVIDIA:mainfrom
ericcurtin:feat/4553-helm-gateway-extra-env/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

Add server.extraEnv so the gateway container can take extra env vars, such as OTEL_*.

Related Issue

Closes #4553

Changes

  • Add server.extraEnv to the gateway pod template.
  • Add unit tests for the StatefulSet and Deployment.
  • Document it in the chart README and gateway configuration docs.

Release Notes

Helm: server.extraEnv adds env vars, including Secret refs, to the gateway container.

Testing

  • Checks appropriate to the affected code and behavior pass (helm unittest, helm lint, mise run helm:docs:check, mise run docs)
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@krishicks @matthewgrossman could you please triage #4553 so the issue check can pass? PTAL, and /ok to test e895b2f2bc81bd8ec5d22feafec5d5efb796e09e if it looks good. Thank you!

@krishicks

Copy link
Copy Markdown
Collaborator

/ok to test e895b2f

@krishicks
krishicks enabled auto-merge October 23, 2026 21:33
@krishicks
krishicks added this pull request to the merge queue Oct 23, 2026
@ericcurtin

Copy link
Copy Markdown
Contributor Author

@krishicks @TaylorMutch thank you for the approval. PTAL when you get a chance to add this to the merge queue.

Merged via the queue into NVIDIA:main with commit 16250df Oct 23, 2026
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(helm): set the gateway's OTEL_* environment variables from chart values

2 participants