Skip to content

docs(skills): add structured security advisory authoring - #4872

Merged
alangou merged 1 commit into
docs/security-ghsa/alangoufrom
docs/4871-security-advisory-skill/alangou
Oct 27, 2026
Merged

alangou merged 1 commit into
docs/security-ghsa/alangoufrom
docs/4871-security-advisory-skill/alangou

Conversation

@alangou

@alangou alangou commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Security reports use inconsistent formats, making reviewers reconstruct deployment prerequisites, tested versions, and supporting evidence. Add the required report template and an internal create-security-advisory skill to prepare structured reports and authorized private GHSA drafts.

Related Issue

Closes #4871

Related pull requests

Stacked on #4832: this PR targets docs/security-ghsa/alangou. Merge it into that branch first, then merge #4832 into main to land the policy and skills together.

Changes

  • Require the template's core headings and supporting reproduction or code evidence. Root cause, CVSS/CWE, and remediation details remain optional.
  • Distinguish reproduced results, code inspection, and unverified claims; keep tested revisions separate from confirmed affected releases.
  • Document duplicate checks, private GitHub draft creation, and read-back verification. Filled reports and payloads stay outside the checkout.
  • Teach review-security-issue to retrieve GHSAs and request missing structure or evidence before technical triage; update the contributor inventory and skill maintenance map.

Testing

  • Skill validator passed for the new skill and the updated security review skill.
  • Markdownlint 0.22.0 passed for all seven affected Markdown files across the stack using repository rules; the advisory description fragment is exempt from the first-level heading requirement.
  • Validated 27 unique skill names, contributor inventory entries, internal metadata, and nine relative links across the stack.
  • npx -y skills add . --list in a disposable copy exposed only the four public skills, preserving internal-skill filtering.
  • git diff --check passed; verified that the child PR contains only the six skill-related files.

Rust, SDK, and E2E suites are not applicable to these guidance and template changes. GitHub advisory creation was not exercised against a live repository.

Checklist

  • Follows Conventional Commits.
  • Commit is signed off for DCO.

@copy-pr-bot

copy-pr-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@alangou
alangou force-pushed the docs/4871-security-advisory-skill/alangou branch from 893f8e4 to a264fde Compare October 23, 2026 14:15
@alangou alangou self-assigned this Oct 23, 2026
@alangou
alangou requested a review from johntmyers October 23, 2026 14:20
@alangou
alangou marked this pull request as ready for review October 23, 2026 14:20
@alangou

alangou commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test a264fde

@alangou
alangou force-pushed the docs/4871-security-advisory-skill/alangou branch from a264fde to 35815bb Compare October 26, 2026 09:32
@alangou
alangou changed the base branch from main to docs/security-ghsa/alangou October 26, 2026 09:32
@alangou
alangou force-pushed the docs/4871-security-advisory-skill/alangou branch 2 times, most recently from 109f691 to 22b64ae Compare October 26, 2026 09:57
@alangou
alangou added this pull request to stack #4923 October 26, 2026 10:02
Signed-off-by: Adrien Langou <alangou@nvidia.com>
@alangou
alangou force-pushed the docs/4871-security-advisory-skill/alangou branch from 22b64ae to e3c613b Compare October 27, 2026 14:28
@alangou
alangou enabled stacked auto-merge October 27, 2026 14:29
@alangou
alangou added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit bd2ecaf Oct 27, 2026
79 checks passed
@alangou
alangou deleted the docs/4871-security-advisory-skill/alangou branch October 27, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(skills): structure private security advisory reports

2 participants