Skip to content

fix(server): close SQLite stores in policy tests - #3466

Merged
drew merged 1 commit into
NVIDIA:mainfrom
kjlubick:fix/sqlite-test-teardown
Sep 18, 2026
Merged

drew merged 1 commit into
NVIDIA:mainfrom
kjlubick:fix/sqlite-test-teardown

Conversation

@kjlubick

Copy link
Copy Markdown
Contributor

Summary

I noticed some flaky tests on Windows and I think this is the reason. This explicitly closes the SQLite-backed test store in four policy tests that intermittently triggered a Windows fail-fast exit (0xc0000409) after the tests had already reported success.

Awaiting store closure allows SQLx's SQLite worker threads and keepalive connection to finish shutting down before the test process exits. This only changes test teardown; it does not change policy behavior.

Related Issue

No issue required: small test fix

Changes

  • Await SQLite store shutdown in the four policy tests observed failing during Windows ARM64 CI.
  • Document why explicit asynchronous cleanup is required.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

The native Windows ARM64 workspace test phase passed three consecutive times.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Kaylee Lubick <klubick@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@kjlubick

Copy link
Copy Markdown
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@drew
drew enabled auto-merge September 18, 2026 18:40
@pimlock

pimlock commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 29e7c90

@drew
drew added this pull request to the merge queue Sep 18, 2026
Merged via the queue into NVIDIA:main with commit fa0bfa4 Sep 18, 2026
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants