fix(server): close SQLite stores in policy tests - #3466
Merged
Merged
Conversation
Signed-off-by: Kaylee Lubick <klubick@nvidia.com>
kjlubick
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 18, 2026 16:20
|
All contributors have signed the DCO ✍️ ✅ |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
drew
approved these changes
Sep 18, 2026
drew
enabled auto-merge
September 18, 2026 18:40
Collaborator
|
/ok to test 29e7c90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed some flaky tests on Windows and I think this is the reason. This explicitly closes the SQLite-backed test store in four policy tests that intermittently triggered a Windows fail-fast exit (
0xc0000409) after the tests had already reported success.Awaiting store closure allows SQLx's SQLite worker threads and keepalive connection to finish shutting down before the test process exits. This only changes test teardown; it does not change policy behavior.
Related Issue
No issue required: small test fix
Changes
Testing
mise run pre-commitpassesThe native Windows ARM64 workspace test phase passed three consecutive times.
Checklist