chore(vm): bump libkrun to v1.19.4 and libkrunfw to v5.6.1 - #3451
Merged
Merged
Conversation
benoitf
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 18, 2026 09:28
Member
|
I think this is already covered in #3446, but yours does add some additional cleanups. |
elezar
reviewed
Sep 18, 2026
10 tasks
The libkrun and libkrunfw projects moved from the containers/ GitHub org to libkrun/. Update all clone URLs and version pins accordingly. libkrun v1.19.4 introduces krun_add_virtiofs4 with a permissions semantics parameter, enabling correct file ownership mapping on host-to-guest bind mounts — required for issue NVIDIA#2585. - libkrun: v1.17.4 → v1.19.4 (libkrun/libkrun) - libkrunfw: 463f717b → v5.6.1 (libkrun/libkrunfw) - Centralise LIBKRUN_REF in pins.env instead of hardcoding in each build script - Source pins.env in the macOS build script for consistency with the Linux build script - Remove the init/init make target step — since libkrun/libkrun@05c4eb7 the init blob moved into the init_blob crate and is built by cargo Ref: NVIDIA#2585 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
bump-libkrun-v1.19.4
branch
from
September 18, 2026 11:59
cd0250f to
5069f35
Compare
Contributor
Author
depending on which PR is merged first, I will do a rebase if mine is second |
elezar
approved these changes
Sep 18, 2026
elezar
enabled auto-merge
September 18, 2026 12:59
Member
|
/ok-to-test 5069f35 |
Member
Let's get this in. I'll rebase the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
463f717bto v5.6.1containers/tolibkrun/for both repositoriesLIBKRUN_REFinpins.envinstead of hardcoding in each build scriptRelated Issue
Ref: #2585
libkrun v1.19.4 introduces
krun_add_virtiofs4with a permissions semantics parameter, enabling correct file ownership mapping on host-to-guest bind mounts.Changes
pins.env: Update libkrunfw to v5.6.1 fromlibkrun/libkrunfw, addLIBKRUN_REF=v1.19.4fromlibkrun/libkrunbuild-libkrun.sh: Update clone URLs to new org, sourceLIBKRUN_REFfrompins.env, remove obsoletemake init/initstep (libkrun@05c4eb7)build-libkrun-macos.sh: Update clone URL to new org, addpins.envsourcing for consistencyTesting
FROM_SOURCE=1 mise run vm:setupsucceeds on Linux (builds libkrunfw v5.6.1 + libkrun v1.19.4 from source)mise run pre-commitpassescargo build -p openshell-driver-vmcompilesChecklist