Conversation
Replace the unary HTTP request evaluator with a bidirectional streaming protocol and move SigV4 signing into the built-in middleware stage. BREAKING CHANGE: replace the unary HTTP request middleware RPC with the streaming HttpRequestPreCredentials Evaluate contract. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 18, 2026 08:06
|
🌿 Preview your docs: https://nvidia-preview-pr-3450.docs.buildwithfern.com/openshell |
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
In auto mode, a bodyless request with no x-amz-content-sha256 falls through to UNSIGNED-PAYLOAD. That's not the normal SigV4 empty-body hash and is service-specific, so a GET/HEAD to a non-S3 AWS service can be re-signed with payload semantics the service rejects. Could BodyFraming::None sign Bytes(&[]) unless the client explicitly requested an unsigned payload, and add a non-S3 empty-body case?
pimlock
marked this pull request as draft
September 18, 2026 16:48
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
14 tasks
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Collaborator
Author
|
/ok to test 96ff945 |
pimlock
marked this pull request as ready for review
September 19, 2026 06:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the WIP HTTP middleware body protocol with the approved two-mode, fail-closed contract. Request middleware now selects bounded in-memory
BUFFEREDprocessing or independent duplexSTREAMprocessing, while response middleware initially offersBUFFEREDonly. OpenShell does not retain STREAM recovery copies or spool middleware bodies to disk.This is the base protocol/runtime PR in a three-PR stack:
The existing inline proxy SigV4 implementation remains in this base PR. Git signing is intentionally excluded.
Related Issue
Part of #2431
Closes #3307
Follow-up to #2426 and #3074.
Changes
EvaluateHttp(stream HttpEvent) returns (stream HttpResult)services with explicit HTTP protocol-version and body-mode capability negotiation.BUFFEREDandSTREAM; remove ownership acknowledgements, sequence/ACK/replay state, skip semantics, and proxy-managed middleware spooling.OutputStartuntil it has consumed the full request.POST_CREDENTIALSphase and reserve its enum value for wire safety.Design artifacts
Testing
mise run pre-commitmise run testmise run cimise run e2eexercised the relevant proxy paths; its aggregate run later hit shared Docker runtime contention inprovider_readiness, which passed when rerun in isolation withOPENSHELL_E2E_DOCKER_TEST=provider_readiness mise run e2e:rustThe first final
mise run ciattempt hit a timing-sensitive plaintext MCP proxy test under maximum parallel load. That test passed in isolation, inmise run test, and in the successful full CI rerun.Checklist