fix(sandbox): pass declared environment to the initial process

[cv]

Summary

Restore declared sandbox environment variables for the initial command. After the RFC 0012 runtime split, those values are carried separately from inherited supervisor environment, but canonical process launch never applies them; applications can therefore start without required configuration even when later exec sessions see it.

Related Issue

Fixes #3377.

Changes

• Apply the declared environment in apply_canonical_process_environment.
• Run supervisor-only environment stripping and provider-placeholder injection afterward in both canonical launch paths, preserving protected-value precedence.
• Add a child-process regression for application variables, explicit HOME, supervisor-token removal, and provider-placeholder precedence.
• Add a Docker-backed lifecycle regression checking initial and exec environments in TTY and non-TTY modes; clarify the documented initial-command contract.

Testing

• mise run pre-commit passes.
• Unit regression fails without environment application; sandbox library suite passes with the fix: 201 passed, one existing skip, using pinned Rust 1.95.0 on Linux ARM64.
• Docker lifecycle regression fails against the original b3e4ad457 sandbox runtime with declared_env=missing and passes against the rebuilt patched runtime in both modes.
• Focused Clippy checks for the sandbox and feature-enabled lifecycle test pass with warnings denied.
• Full mise run ci passes on Linux ARM64 after installing the required libz3-dev dependency. The first run hit two WebSocket test failures in openshell-supervisor-network; both passed in an isolated serial run, and an unchanged full CI rerun passed. No source changes were needed.

The Docker comparison used the same b3e4ad457 gateway and supervisor, the same workload image from #3377, and a CLI built from this branch. Only the sandbox runtime image changed between failing and passing runs. Tests used an isolated temporary gateway and owned sandboxes; no images were published. This verifies environment propagation, not NemoClaw model inference.

Checklist

• Follows Conventional Commits.
• Commits are signed off (DCO).
• Architecture and user documentation updated.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[github-actions]

All contributors have signed the DCO ✍️ ✅
_{Posted by the DCO Assistant Lite bot.}

[cv]

I have read the DCO document and I hereby sign the DCO.

[drew]

/ok to test 4c5c661

[github-actions]

Label test:e2e applied for 4c5c661. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

[johntmyers]

gator-agent

PR Review Status

This focused fix restores declared environment variables to the initial sandbox process while preserving supervisor-only stripping and provider-placeholder precedence in both canonical launch paths. The implementation, regression coverage, architecture note, and user documentation are consistent, and no blocking findings remain.

Blocking findings:

• No blocking findings remain

Carried findings:

• None

Non-blocking suggestions:

• None

Gator metadata

• Validation: Project-valid focused fix for linked regression #3377
• Docs: Relevant Fern sandbox documentation and architecture contract updated
• Checks: Branch Checks, Helm Lint, and Trivy Changes are green; required E2E is queued for the current head
• E2E: test:e2e applied; E2E Label Help requested rerun 35141913252, which is queued
• Head SHA: 4c5c661f84930973c46b00f7e628ffe4934bc183
• Base SHA: 7c592196e74ce4e512e43af8cb4faa7b19473b96
• Merge base SHA: 2ccef97769e0e39c4dc06b4c3953d3735814f146
• Patch ID: 881708d22062297530fd947d58194b8a50eddb39
• Gator payload: 9
• Review mode: initial
• Previous reviewed SHA: none
• Review budget exhausted: no
• Maintainer decision required: no
• Next state: gator:watch-pipeline

[johntmyers]

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: Gator review found no blocking issues, the required checks including E2E passed, and maintainer approval was present before merge.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.

Gator metadata

• Head SHA: 4c5c661f84930973c46b00f7e628ffe4934bc183
• Gator payload: 9