feat(api)!: use sandbox names as canonical RPC references - #3272
Draft
drew wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 11, 2026 05:28
11 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-3272.docs.buildwithfern.com/openshell |
drew
marked this pull request as draft
September 11, 2026 05:56
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
elezar
reviewed
Sep 11, 2026
| persisted sandbox record and authorizes that record's workspace. Missing and | ||
| unauthorized references use the same response within each principal class so | ||
| the resolver does not expose an object-existence oracle. Sandbox, sandbox | ||
| template, provider, and service list RPCs also accept an all-workspaces marker |
Member
There was a problem hiding this comment.
Does this mean that the workspace, sandbox name are the unique identifier for the sandbox? (If I recall correctly, I saw an issue where users in different workspaces can delete / access a sandbox if they create one with the same name. Does this solve that?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize public sandbox references on the human-readable sandbox name. Every sandbox-scoped gateway RPC now accepts a string
sandboxwith workspace selection carried separately, while canonical sandbox IDs remain internal metadata for authentication, persistence, and compute-driver boundaries.Related Issue
Closes #3050
Changes
SandboxReferencewrapper and public ID references withsandboxstrings.Testing
mise run pre-commitpassescargo test -p openshell-serverwith an isolated system gateway directory (1,463 tests)cargo test -p openshell-cli -p openshell-tuimise run sdk:ts:ci(105 tests)uv run --frozen pytest python/openshell/sandbox_test.py(130 tests)mise run go:ci(three unrelated gateway-discovery tests observe/etc/openshell/gateways/defaulton this development host)Checklist