Skip to content

fix(mxc): resolve Windows ETW Clippy lints - #3270

Merged
pimlock merged 1 commit into
mainfrom
fix-windows-arm64-clippy/pm
Sep 11, 2026
Merged

fix(mxc): resolve Windows ETW Clippy lints#3270
pimlock merged 1 commit into
mainfrom
fix-windows-arm64-clippy/pm

Conversation

@pimlock

@pimlock pimlock commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Resolve the Clippy warnings introduced by #3015 that break the Windows arm64 lint job. The changes follow Clippy's idiomatic rewrites without changing ETW capture, attribution, or OCSF behavior.

Related Issue

No issue required: this is a localized mechanical follow-up to #3015 and Actions job 103116524277.

Changes

  • Simplify control flow and Option/Result handling flagged by Clippy.
  • Use the mutable pointer and explicit unsigned-cast APIs for ETW interop.
  • Replace allocation-heavy GUID formatting and clean up documentation formatting.
  • Update test fixtures to use direct struct initialization and checked Instant subtraction.

Testing

  • mise run --skip-tools windows:lint:arm64
  • mise run pre-commit

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Automated follow-up for #3015 and Actions job 103116524277

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@pimlock

pimlock commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 8dd3e60

@pimlock pimlock added the test:windows Run native Windows x64 and ARM64 lint/tests on PR mirrors label Sep 11, 2026
@pimlock
pimlock enabled auto-merge September 11, 2026 04:15
@pimlock
pimlock added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 3112e9c Sep 11, 2026
65 of 67 checks passed
@pimlock
pimlock deleted the fix-windows-arm64-clippy/pm branch September 11, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:windows Run native Windows x64 and ARM64 lint/tests on PR mirrors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants