feat(supervisor): apply streamed configuration snapshots - #3265
Open
pimlock wants to merge 3 commits into
Open
Conversation
pimlock
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 10, 2026 22:49
|
🌿 Preview your docs: https://nvidia-preview-pr-3265.docs.buildwithfern.com/openshell |
pimlock
added this pull request to stack #3266
September 10, 2026 23:38
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
force-pushed
the
1731-config-update-stage-2/pimlock
branch
from
September 11, 2026 02:08
e2b8a35 to
797c36e
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initialize supervisors and apply live configuration updates through
ConnectSupervisor. Protocol revision 2 uses streamed snapshots and requires successful bootstrap before the gateway marks a supervisor initialized. Older protocol revisions retain polling compatibility.Before-and-after Stage 2 walkthrough
Related Issue
Part of #1731.
Stacked on #3244.
Changes
Testing
mise run pre-commitmise run cimise run e2e:dockerKnown reliability issue observed under load
A focused reproduction with 32 running sandboxes and 32 concurrent exec clients produced 6 false exit-code-1 results across 37,376 exec calls, including commands that explicitly ran
exit 0. Diagnostic logs confirmed that the orphan reaper collected a child's exit status 0 before SSH's waiter receivedECHILDand substituted exit code 1. No policy changes or gateway restart were needed.The implicated spawn/register/reap code predates this PR. Existing fix commit
c5cf4ec2bis included in #3142.Checklist