feat(gateway): support selective compute driver builds - #3118
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-3118.docs.buildwithfern.com/openshell |
|
Label |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
This maintainer-authored implementation matches the linked selective-driver-build request. The full initial code review found no blocking issues, the user-facing build instructions are documented, and the required E2E workflow is now running for the current head.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Non-blocking suggestions:
- None
Gator metadata
- Validation: Project-valid via linked issue #1943 and maintainer authorization
- Docs: Fern reference docs and supporting build/architecture guidance updated
- Checks: Current-head branch checks are pending
- E2E:
test:e2eapplied; Branch E2E Checks run34540933422, attempt 2, is in progress - Head SHA:
997478b25789ec67cb39116de1bab0169e45de47 - Base SHA:
3c0f58872ea956816abf82cdf50fa94601329cc5 - Merge base SHA:
3c0f58872ea956816abf82cdf50fa94601329cc5 - Patch ID:
d7c0170d6a03be7f1c7a84d5a251efc204ec7c88 - Gator payload:
9 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The follow-up review of Drew's Windows MXC selective-build update found no blocking code issues. GitHub now reports that the current head conflicts with the base branch, so pipeline monitoring cannot advance until the branch is updated.
Action required: @drew, resolve the merge conflict against the current base branch and push the updated head.
Blocking findings:
- No blocking code findings remain
Carried findings:
- None
Gator metadata
- Validation: Project-valid via linked issue #1943 and prior maintainer authorization
- Docs: Fern compute-driver reference and supporting build/architecture guidance updated
- Checks: Current-head Branch Checks and E2E are in progress; merge conflict blocks progression
- E2E:
test:e2eis applied; Branch E2E Checks run34544402357, attempt 1, is in progress - Head SHA:
b7f5840f6c181da1abb58787d0e620604538a7dd - Base SHA:
3c0f58872ea956816abf82cdf50fa94601329cc5 - Merge base SHA:
3c0f58872ea956816abf82cdf50fa94601329cc5 - Patch ID:
7812029854b85bf91186c83062c90632e6b8ea5b - Gator payload:
9 - Review mode:
follow_up - Previous reviewed SHA:
997478b25789ec67cb39116de1bab0169e45de47 - Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:blocked - Blocked reason:
merge_conflict
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
b7f5840 to
2d37529
Compare
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Drew's rebase resolved the merge conflict. I reviewed the author-only delta from the previous gator head and found no blocking issues; the current-head Branch Checks, Windows MSVC, and E2E workflows are running.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Gator metadata
- Validation: Project-valid via linked issue #1943 and maintainer authorization
- Docs: Fern compute-driver reference and supporting build/architecture guidance are updated
- Checks: Current-head required checks are queued or in progress; no failures observed
- E2E:
test:e2eremains applied; Branch E2E Checks run34545788001, attempt 1, is in progress for the current head - Head SHA:
2d375294014042c4efeffd68026961299ffbb739 - Base SHA:
1860010850d3c1520d4f5d82f7c30b6a366bb747 - Merge base SHA:
ddc8bba9677ed8413849c8f148364df2f0146a6d - Patch ID:
7251487dceac3bd95686c7fe0c5ec284083b93e8 - Gator payload:
9 - Review mode:
follow_up - Previous reviewed SHA:
b7f5840f6c181da1abb58787d0e620604538a7dd - Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: Gator review completed with no blocking findings, maintainer approval was present, and the PR reached I removed the active |
Summary
Allow gateway builders to compile any subset of the Kubernetes, Docker, Podman, VM, and Windows MXC compute drivers while preserving the existing platform defaults.
Selective features live in
openshell-gateway, which owns driver composition after the server refactor.openshell-serverremains backend-independent. Protocol-only builds remain valid, and omitted built-in drivers can still resolve to operator-supplied external endpoints.Related Issue
Closes #1943
Direct maintainer authorization was provided despite the issue's stale lifecycle label.
Changes
compute-driver-kubernetes,compute-driver-docker,compute-driver-podman,compute-driver-vm, andcompute-driver-mxcCargo features toopenshell-gateway.in-tree-compute-driversas the default compatibility alias, including Windows MXC registration and unsupported-driver stubs.Testing
mise run pre-commit.tasks/scripts/verify-defaults-without-telemetry.sh.mise run e2e:gateway:no-compute-drivers.OPENSHELL_SYSTEM_GATEWAY_DIR=/tmp/pr3118-system-config mise run testwith an empty system gateway directory.The initial unisolated test run reproduced the previously documented CLI gateway-completion failure caused by the host's system gateway configuration. The isolated run avoids that host state. Native Windows tests were not run on this Linux host.
Checklist