Skip to content

refactor(test): group process recovery coverage - #10138

Merged
cv merged 2 commits into
mainfrom
refactor/test-directory-structure-2
Aug 24, 2026
Merged

refactor(test): group process recovery coverage#10138
cv merged 2 commits into
mainfrom
refactor/test-directory-structure-2

Conversation

@cv

@cv cv commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Group process and forward recovery integration tests under one behavior-owned directory without changing their Vitest execution lane.

Changes

  • Move six process-recovery test files into test/process-recovery/ and update their source imports.
  • Update security review, source comment, and E2E parity references to the relocated tests.
  • Document process-recovery/ as an integration-project behavior directory.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable — Normal pre-commit, commit-msg, and pre-push hooks passed.
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npm run test:projects:check; npx vitest run --project integration test/process-recovery (147 passed); npm run checks:repository; npm run typecheck:cli
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result: Focused validation and repository hooks passed; broad matrix deferred to required CI.
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

  • Documentation

    • Clarified integration-test organization for sandbox process and forward-recovery coverage.
  • Tests

    • Updated recovery test references and import paths following test reorganization.
    • Preserved existing recovery, forwarding, authentication, secret-boundary, and failure-handling coverage.
    • Refined test formatting and compatibility references without changing expected behavior.
    • Updated integration test shard assignments to maintain stable coverage distribution.

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv self-assigned this Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5b409ca8-7c1c-459e-8f50-bacc19fd0240

📥 Commits

Reviewing files that changed from the base of the PR and between 919ec29 and a348ae2.

📒 Files selected for processing (2)
  • test/cli-coverage-sequencer.test.ts
  • test/helpers/cli-coverage-sequencer.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates process recovery test references and module paths for the reorganized test/process-recovery/ directory. It also updates integration shard assignments and reformats selected tests without changing their recovery behavior.

Changes

Process recovery test organization

Layer / File(s) Summary
Update process recovery test references
internal/security-reviews/..., src/lib/actions/sandbox/forward-recovery.ts, test/README.md, test/e2e/mock-parity.json
References and guidance now use the reorganized process recovery test paths.
Correct test module paths and assertions
test/process-recovery/*
Tests now resolve source modules through ../../src. Selected formatting and one error assertion changed without changing recovery expectations.
Remap integration coverage shards
test/helpers/cli-coverage-sequencer.ts, test/cli-coverage-sequencer.test.ts
The shard salt and expected assignments for three integration test keys were updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a348a

This PR reorganizes process-recovery tests and updates their references without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: aasthajh, brandonpelfrey

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 9 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: grouping process recovery test coverage under a dedicated directory.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/test-directory-structure-2

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit a348ae2 in the refactor/test-direct... branch remains at 96%, unchanged from commit 90da7cc in the main branch.

TypeScript / code-coverage/cli

The overall line coverage in commit a348ae2 in the refactor/test-direct... branch remains at 84%, unchanged from commit 90da7cc in the main branch.

Show a line coverage summary of the most impacted files.
File main 90da7cc refactor/test-direct... a348ae2 +/-
src/lib/actions...e-classifier.ts 75% 57% -18%
src/lib/policy/index.ts 76% 65% -11%
src/lib/sandbox/config.ts 83% 72% -11%
src/lib/actions...estroy-phase.ts 93% 86% -7%
src/lib/onboard.ts 54% 53% -1%
src/lib/shields/index.ts 80% 82% +2%
src/lib/state/p...l-retirement.ts 77% 79% +2%
src/lib/state/sandbox.ts 86% 91% +5%
src/lib/state/m...-acquisition.ts 82% 88% +6%
src/lib/cli/com...and-registry.ts 59% 94% +35%

Updated August 24, 2026 19:08 UTC

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
cv merged commit fef6887 into main Aug 24, 2026
71 of 80 checks passed
@cv
cv deleted the refactor/test-directory-structure-2 branch August 24, 2026 19:13
@github-actions github-actions Bot added the v0.0.115 Release target label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v0.0.115 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant