fix(mcp): preserve external policy authority - #10119
Conversation
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 230dfb2 in the Show a line coverage summary of the most impacted files.
Updated |
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
The MCP discovery failures came from remove using an empty network-policy map as an authority probe. The policy parser correctly rejects that map before inspection. Verified commit 7d8081e uses a valid capability-free per-server entry for managed removal. Recorded external authority requires the exact rendered MCP policy immediately; legacy external authority retries only after preflight persists external authority, and still verifies the exact policy before mutation. Verification:
CI is rerunning with the corrected authority qualification. |
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Summary
MCP bridge add, remove, restart, rebuild, and destroy operations now retain exact policy-authority receipts. Authority drift stops further policy-sensitive mutation and suppresses success publication.
Related Issue
Part of #9833
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Apurv Kumaria akumaria@nvidia.com