[codex] Harden Retriever harness artifact safety#2286
Draft
jioffe502 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--jsonresultsRoot cause
Artifact writes bypassed
ArtifactWriterin several execution paths, the result manifest inferred current artifacts by scanning known filenames, and writer initialization happened outside artifact-failure handling. As a result, resolved secrets could be serialized directly, reused directories could advertise stale files, and I/O failures could surface as exit 70 or an uncaught traceback.Impact
Harness consumers can continue treating artifacts and exit codes as the stable interface. Structured artifacts and JSON output no longer expose credential fields, manifests describe only the current run, unsafe directory reuse fails before mutation, and artifact failures consistently report exit 30.
Validation
uvx pre-commit run --files ...(all configured hooks passed)uv run pytest -q tests/test_harness_artifact_protocol.py tests/test_beir_evaluation.py(34 passed)jp20_beir --dry-run --jsonwith a reranker API-key override: exit 0, complete status, secret absent from stdout and structured artifacts, no execution-only artifacts in the manifest