Dev/mahikaw/agentic enhancements#2274
Draft
mahikaw wants to merge 6 commits into
Draft
Conversation
The --agentic path wrapped the run in quiet_capture(), which discards stdout/ stderr on success, so a multi-step ReAct query produced no feedback. Mirror the `pipeline run` logging setup (logging.basicConfig at INFO; defaults to stderr) so the operators' existing per-query/step/tool-call logs surface, while stdout stays clean JSON. Dense path unchanged. Signed-off-by: Mahika Wason <mwason@nvidia.com>
Agentic retrieval reduced each hit to {doc_id,text,score} at the agent boundary
and returned bare doc_ids, unlike the dense path which returns full RetrievalHit.
Cache the full hit (keyed by doc_id) in _retrieve_for_agent, then re-hydrate the
selected doc_ids at output time so agentic_query_documents returns RetrievalHit
metadata (text/source/page_number/pdf_page/metadata/...) plus the agentic
annotations (doc_id/rank/result_source). Addresses review feedback (jperez999).
Signed-off-by: Mahika Wason <mwason@nvidia.com>
--agentic-llm-model is no longer required: it defaults to nvidia/llama-3.3-nemotron-super-49b-v1.5 (also settable via the NEMO_RETRIEVER_AGENTIC_LLM_MODEL env var), so --agentic works standalone. Signed-off-by: Mahika Wason <mwason@nvidia.com>
These retrieval-shaping flags were silently dropped in agentic mode. Thread them from QueryRetrievalOptions into AgenticRetrievalConfig and forward to the per-hop Retriever.query call (candidate_k floored at the hop's top_k), matching how the dense path applies them. Signed-off-by: Mahika Wason <mwason@nvidia.com>
3 tasks
…nhancements # Conflicts: # nemo_retriever/src/nemo_retriever/cli/query/options.py
mahikaw
force-pushed
the
dev/mahikaw/agentic-enhancements
branch
from
dea4482 to
fed8ce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist