chore(studio): Chat Style update#497
Open
dmariali wants to merge 3 commits into
Open
Conversation
Signed-off-by: Danielle Ali <44468613+dmariali@users.noreply.github.com>
dmariali
force-pushed
the
chat-rendering-update
branch
from
7371a02 to
7b4eed3
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdates chat message layout, markdown and code rendering, tool-call styling, and Claude Code runtime resume behavior. ChangesChat UI restyling
Assistant message resume logic
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@web/packages/common/src/components/Chat/MessageContent/markdownComponents.tsx`:
- Around line 52-59: The list item styling change in the markdown components
still won’t affect the common list-item path because renderListItemChildren in
helpers.tsx wraps the first paragraph with its own leading-[160%]. Update that
helper alongside the li renderer in markdownComponents.tsx so the first
paragraph uses the same leading as the rest of the list item, keeping list
density consistent across both paths.
In
`@web/packages/studio/src/routes/agents/ClaudeCodeChatRoute/useCustomAssistantChatRuntime.ts`:
- Around line 204-223: The resumed assistant message flow in
useCustomAssistantChatRuntime should preserve existing parts when
setAssistantText() is called after resumeLastAssistantMessage() seeds
responseContent from the previous completed message. Update the setAssistantText
path to append or replace only the text portion of the current assistant content
instead of clearing responseContent, so earlier tool calls and prior assistant
text remain intact in the message transcript. Use the existing
resumeLastAssistantMessage(), setAssistantText(), responseContent, and
updateAssistantMessageContent() logic to keep resumed parts preserved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e0557e8b-bc6a-4c27-93ae-459f10f769e9
📒 Files selected for processing (15)
web/packages/common/src/components/AssistantChat/AssistantChatThread.tsxweb/packages/common/src/components/AssistantChat/AssistantMessage.tsxweb/packages/common/src/components/AssistantChat/UserEditComposer.tsxweb/packages/common/src/components/AssistantChat/UserMessage.tsxweb/packages/common/src/components/AssistantChat/messageActions.tsxweb/packages/common/src/components/Chat/MessageContent/MarkdownParagraph.tsxweb/packages/common/src/components/Chat/MessageContent/index.test.tsxweb/packages/common/src/components/Chat/MessageContent/index.tsxweb/packages/common/src/components/Chat/MessageContent/markdownComponents.tsxweb/packages/common/src/components/CodeDisplay/index.test.tsxweb/packages/common/src/components/CodeDisplay/index.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/ClaudeCodeToolCallPart.test.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/toolCall/SubtleToolCallRow.tsxweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/useCustomAssistantChatRuntime.test.tsweb/packages/studio/src/routes/agents/ClaudeCodeChatRoute/useCustomAssistantChatRuntime.ts
Comment on lines
52
to
59
| li: ({ children, className }) => ( | ||
| <li | ||
| className={cn( | ||
| 'mb-density-sm whitespace-normal pl-density-xs text-sm leading-[160%] last:mb-0 [&>p]:my-0', | ||
| 'mb-density-xs whitespace-normal pl-density-xs text-sm leading-6 last:mb-0 [&>p]:my-0', | ||
| className | ||
| )} | ||
| > | ||
| {renderListItemChildren(children)} |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
List bullets still keep the old leading on their first paragraph.
renderListItemChildren in web/packages/common/src/components/Chat/MessageContent/helpers.tsx:36-51 still wraps the first paragraph with leading-[160%], so this leading-6 change will not apply to the common list-item path. Update the helper span at the same time or the new density stays inconsistent.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@web/packages/common/src/components/Chat/MessageContent/markdownComponents.tsx`
around lines 52 - 59, The list item styling change in the markdown components
still won’t affect the common list-item path because renderListItemChildren in
helpers.tsx wraps the first paragraph with its own leading-[160%]. Update that
helper alongside the li renderer in markdownComponents.tsx so the first
paragraph uses the same leading as the rest of the list item, keeping list
density consistent across both paths.
Contributor
|
Signed-off-by: Danielle Ali <44468613+dmariali@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: I have a follow up commit to this specifically for the super long messages in coding agent which will collapse everything before and present a summary of what was done. The messages are long as heck, there's no getting around that. This is an attempt to make them more palatable.
Summary by CodeRabbit
Summary by CodeRabbit
New Features
UI Improvements