Conversation
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
guyueh1
marked this pull request as ready for review
September 15, 2026 22:14
Signed-off-by: Guyue Huang <guyueh@nvidia.com> # Conflicts: # nemo_rl/models/generation/vllm/config.py # nemo_rl/models/megatron/setup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generation.vllm_cfg.fp32_lm_headtoggle and thread it into vLLM source patchingTesting
/Users/guyueh/.local/share/nel/venvs/nel-next/bin/ruff format --check .../Users/guyueh/.local/share/nel/venvs/nel-next/bin/ruff check .../Users/guyueh/.local/share/nel/venvs/nel-next/bin/python -m py_compile ...git diff --checkNotes
uvis not on PATH in this shell, the cached pytest env is missingomegaconf, and importing the vLLM package path in that env hits missingnemo.lens/Users/guyueh/Documents/work/code/RL/.venv/bin/pythonis missingpre_commit, so the signed-off commit was created with--no-verifyafter the targeted checks above