Conversation
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
Root-cause validation completed on GB200. The broken HybridEP run used sequence packing without either NeMo-RL pre-padding or Megatron-Core uneven-input padding. Its generation KL error was already 0.8066 at step 1, before any optimizer update or refit, and averaged 0.7985. This isolates the failure to training-side policy logprobs rather than the refit path. With this change, the same Qwen3.5-35B-A3B Async/NCCL Reshard configuration completed 20/20 steps. Generation KL error averaged 0.00136 with a 0.00095-0.00215 range. |
Contributor
Author
|
Self-review completed on head
|
Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
/ok to test 5caf656 |
Signed-off-by: seonjinn <sna@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guarantee aligned token counts for HybridEP when sequence packing is enabled.
Why
Packed lengths can differ across expert-parallel ranks. Without one alignment owner, HybridEP collectives can consume different token counts and silently corrupt policy logprobs or hang.
How
Test