Repository navigation
Conversation
This was referenced Oct 5, 2026
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Pouyanpi
force-pushed
the
pouyanpi/openai-chat-streaming-integration-4
branch
from
October 6, 2026 11:05
9861450 to
229e31a
Compare
Pouyanpi
marked this pull request as ready for review
October 6, 2026 11:06
Pouyanpi
force-pushed
the
pouyanpi/openai-chat-streaming-integration-4
branch
from
October 6, 2026 15:22
229e31a to
52b1d88
Compare
Contributor
|
Pouyanpi
force-pushed
the
pouyanpi/openai-chat-streaming-integration-4
branch
2 times, most recently
from
October 7, 2026 09:00
cc48787 to
1058fe8
Compare
Pouyanpi
force-pushed
the
pouyanpi/openai-chat-streaming-integration-4
branch
from
October 8, 2026 17:52
1058fe8 to
6269303
Compare
This was referenced Oct 8, 2026
Pouyanpi
added this pull request to stack #2445
October 9, 2026 13:16
Contributor
Pouyanpi
force-pushed
the
pouyanpi/openai-chat-streaming-integration-4
branch
from
October 9, 2026 14:17
6269303 to
7601b81
Compare
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Advertise the text/event-stream success response only when the router has both a stream adapter and streaming dispatch, since streaming requests are rejected before dispatch otherwise. Remove the unused first construction of the buffered operation, which the factory replaced before returning. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
The endpoint now binds the stream classifier and a fresh hook instance per request, and the router dispatches either response mode. State that the buffered contract export stays buffered-only. Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Pouyanpi
force-pushed
the
pouyanpi/openai-chat-streaming-integration-4
branch
from
October 9, 2026 15:22
7601b81 to
33d8179
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the preceding OpenAI Chat stream modules and HTTP bridge with the existing guarded endpoint. Buffered and streaming requests share one input projection and check.
What Changed
Review Notes
Review target-state continuity, one input check, request-local hooks, error disclosure, and buffered regressions. The stream projection, classifier, and hooks are supplied by part 2; the HTTP bridge is supplied by part 3. Concrete outbound HTTP, application configuration, live recordings, and replacement execution remain separate work.
AI Assistance
Checklist
Stack Position
Part 4 of 4.
Stack Context
Adds OpenAI Chat streaming above #2414 in four parts: provider-neutral execution, typed OpenAI stream declarations and handwritten hooks, injected HTTP lifecycle handling, and integration with the buffered request pipeline.
The open chain is #2411 → #2413 → #2414 → #2434 → #2435 → #2436 → #2437. #2412 is closed; its provider provenance and boundary documentation are included in #2413.
Python declarations own field and event policy. Hooks are handwritten and created for each stream by the integration. The shared exporter currently emits buffered policy; streaming contract export remains separate work. Concrete outbound HTTP, deployment configuration, and replacement execution land separately.
Review each PR against its listed base branch.
pouyanpi/transparent-proxy-streaming-kernel-1pouyanpi/openai-chat-buffered-integration-4pouyanpi/openai-chat-streaming-contract-2pouyanpi/transparent-proxy-streaming-kernel-1pouyanpi/transparent-proxy-streaming-http-3pouyanpi/openai-chat-streaming-contract-2pouyanpi/openai-chat-streaming-integration-4pouyanpi/transparent-proxy-streaming-http-3Summary by CodeRabbit