Repository navigation
feat(server): classify guarded projection outcomes - #2407
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA-NeMo/Guardrails/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughGuarded message projections can now indicate that inspection does not apply or raise an unsupported-payload failure. Buffered operations report projection failures by stage, and the HTTP renderer accepts those failures. ChangesProjection outcome handling
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No actionable issue is established for this PR; it is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
318d79c to
81e71a7
Compare
tgasser-nv
left a comment
There was a problem hiding this comment.
Looks good, just one nit
7997b7d to
08fc1a2
Compare
tgasser-nv
left a comment
There was a problem hiding this comment.
Looks good, approving
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
08fc1a2 to
2121b0a
Compare
Description
Phase A establishes the private provider-neutral foundations for transparent provider proxying. This PR completes the provider-neutral projection boundary before provider integration is added.
It adds:
This layer does not decide which status codes or payloads contain content to inspect. Each provider binding owns that declaration.
Together with the checker and HTTP outcomes from the preceding PRs, these values form a provider-neutral failure model. A provider integration must use one provider-owned mapping for native runtime envelopes, stable error codes, and OpenAPI documentation so those representations cannot drift.
Stable and temporary parts
The semantic projection outcomes and their fail-closed ordering are intended to remain provider-neutral. They are not temporary HTTP error models.
The injected renderer is the narrow part: provider integration later maps the same outcomes to native status codes and response envelopes and uses the same mapping for OpenAPI documentation. Each provider binding also decides which responses contain content to inspect.
ContentInspectionNotApplicableis not a general bypass for successful output.Review focus
Non-goals
Phase A stack
Review every PR against its parent branch rather than against
develop, except for PR 1.pouyanpi/transparent-proxy-kernel-1developpouyanpi/transparent-proxy-buffered-kernel-2pouyanpi/transparent-proxy-kernel-1pouyanpi/transparent-proxy-http-kernel-3pouyanpi/transparent-proxy-buffered-kernel-2pouyanpi/transparent-proxy-projection-outcomes-4pouyanpi/transparent-proxy-http-kernel-3AI Assistance
Checklist