Fix local dataframe extension detection#779
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Contributor
Linked Issue CheckThis PR does not reference an issue. External contributions must link to Add one of the following to your PR description:
If no issue exists yet, open one See CONTRIBUTING.md |
Contributor
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.suffixbehaves like a real path.csv,.json, and.parquetinputs via bothPathandstrWhy
The local-file branch of
smart_load_dataframe()usedPath.suffix.lower(), which returns values like.csv. The loader dispatch compared that againstcsv,json, andparquet, so valid local files could fall through toUnsupported file format.The existing test mocked
suffix.lower()to returncsvwithout the dot, which masked the bug. The new regression test writes actual files and exercises the real path behavior.Testing
uv run --package data-designer-config pytest packages/data-designer-config/tests/config/utils/test_io_helpers.pyuv run ruff check packages/data-designer-config/src/data_designer/config/utils/io_helpers.py packages/data-designer-config/tests/config/utils/test_io_helpers.pyuv run ruff format --check packages/data-designer-config/src/data_designer/config/utils/io_helpers.py packages/data-designer-config/tests/config/utils/test_io_helpers.py