Keep Python version info out of the source tree - #242
Open
Daniiiil1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass setuptools' finalized
build_libpath into the version-info generator instead of always deriving an output directory from the process working directory.Root cause
ament_pythoninvokessetup.pyfrom the package source directory. Building the path fromos.getcwd()therefore creates<source>/build/version_info.yamland leaves the checkout dirty even when colcon is configured for an out-of-source build.The optional
build_dirargument preserves the existing fallback for direct callers whileGenerateVersionInfoCommanduses the correct setuptools build location. Installation toshare/<package>is unchanged.Validation
python3 -m py_compile isaac_ros_common/scripts/isaac_ros_common-version-info.pybuilddirectory is createdCloses #239