Repository navigation
Conversation
2 of 6 tasks
A user on a fresh Ubuntu 26.04 ran `curl -fsSL brig.sh/install | sh` and got the rootless refusal. Three parts of it did not hold for them: - "Nothing was downloaded" was not true. brig's installer had already fetched cosign (about 130 MB), the brig archive and this script. The message now says that the installer stopped before it downloaded the bundle. - "See docs/rootless.md" pointed at a checkout the user does not have. The refusal, the install summary and --help now give the guide's URL. - "run this installer again" named a script the user never ran. INSTALL_BRIG_RERUN lets the caller say how to run the install again, and the refusal prints that command after the root commands. Without it the message is unchanged. The modules-load.d comment named brig-rootless-setup.sh, which this installer's root commands do not run. Both copies now say "brig's rootless setup". Signed-off-by: Anastassios Nanos <ananos@nofire.ai>
ananos
force-pushed
the
fix/rootless-refusal-text
branch
from
October 31, 2026 16:16
81e098a to
5346033
Compare
ananos
marked this pull request as ready for review
October 31, 2026 16:17
1 of 6 tasks
pmoust
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user on a fresh Ubuntu 26.04 ran
curl -fsSL brig.sh/install | sh(brig v0.5.0, rc19) and got the rootless refusal. The refusal itself is right: the host had nouidmap, noacland novhost_vsock. Three parts of the message did not hold for them, though:brig's installer had already fetched cosign (about 130 MB), the brig archive and this script.
docs/rootless.mdis a path in a checkout they do not have. "this installer" is a script they never ran directly.This is on top of #36, which installs the packages itself when sudo can run. The refusal is still what a user without sudo, or without a terminal, gets.
Changes
--helpgive the guide's URL (ROOTLESS_DOC).INSTALL_BRIG_RERUN: the caller passes the command that runs the install again, and the refusal prints it after the root commands. Unset, nothing extra is printed. brig'sinstall.shwill passcurl -fsSL https://brig.sh/install | sh(fix(install): Keep cosign across runs and say how to run again brig-sh/brig#555).modules-load.dcomment, ininstall.shand in the generatedbrig-rootless-setup.sh, says "brig's rootless setup" instead of naming a script the root commands do not run.docs/rootless.md: the sample refusal matches the new text.tests/install-preflight.sh: checks the new reason, the URL, that no command is printed withoutINSTALL_BRIG_RERUN, and that it is printed afterBRIG_ROOTwhen set.Tested
Locally (macOS):
sh -nand shellcheck overinstall.sh scripts/build-bundle.sh tests/*.sh. In a Debian trixie container withoutuidmapandacl, as a normal user, everytests/*.shpasses, including #36's sudo and password cases (CI skips those, since its runner has both packages).Not tested: the printed root commands on Ubuntu 26.04 itself.
Release sequence
For rc21. The brig side only sets an environment variable, so either can merge first.