Repository navigation
Conversation
The line the summary prints is for a shell's startup file, and it gave the expanded home path. It now says $HOME, which is what that file usually holds, and a home path with a quote, a $ or a backtick in it no longer breaks the line. A PATH entry with a trailing slash, such as ~/.local/bin/, was not counted as the launcher directory, so that user was told to add what they had. Refs: #25 Signed-off-by: Panagiotis Moustafellos <pmoust@nofire.ai>
pmoust
marked this pull request as ready for review
October 31, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #26 from review.
The summary's line is for a shell's startup file, and it printed the expanded home path. It now prints
export PATH="$HOME/.local/bin:$PATH", which is what #25 asked for, and a home path with a quote, a$or a backtick no longer breaks the line.A
PATHentry with a trailing slash, such as~/.local/bin/, did not count as the launcher directory, so that user was told to add what they had.tests/install-summary.shasserts both, and shellcheck passes. Run in a Debian container as a normal user with a subuid range: it passes with this change, and the PATH-line check fails on the installer from main. Not run on a real install.Refs: #25