Repository navigation
Weekly Merge: stable-nightly to develop (20261101) - #2312
Conversation
|
Ursa GDASApp CI |
|
WCOSS2 (Cactus) GDASApp CI |
CI Run Summary for PR #2312 (Commit: b832816)Automated GW-GDASApp Testing Results: CI Status: Passed |
CI Run Summary for PR #2312 (Commit: b832816)Automated GW-GDASApp Testing Results: CI Status: Passed |
CI Run Summary for PR #2312 (Commit: b832816)Automated GW-GDASApp Testing Results: CI Status: Passed |
CI Run Summary for PR #2312 (Commit: b832816)Automated GW-GDASApp Testing Results: CI Status: Passed |
CI Run Summary for PR #2312 (Commit: b832816)Automated GW-GDASApp Testing Results: CI Status: Passed |
CI Run Summary for PR #2312 (Commit: b832816)Automated GW-GDASApp Testing Results: CI Status: Passed |
There was a problem hiding this comment.
🔵 Needs a closer look
The change depends on the deployed upstream JEDI/SOCA writer interface version, which cannot be verified within the repository and shows unresolved inconsistencies between aero and soil configs.
No open issues 🎉
What changed in this PR
This is an automated weekly sync PR that merges stable-nightly into develop (dated 20261101). The substantive content is a set of upstream JEDI/JCB interface updates to the GDAS configuration client, primarily flattening the increment-writer templates (removing the output:/state component: wrapper so it is supplied by the consuming algorithm template) and adopting newer SOCA/fv3-jedi writer fields (times:, ISO-formatted date:, variables:). It also adjusts the weekly-PR cron schedule and refreshes a test reference file to include the new increment-print block.
Changes:
- Flatten
output:/state component:nesting out of all*_final_increment*.yaml.j2writer templates (atmosphere, marine, aero, snow, soil) consistently. - Adopt updated writer fields: add
times:lists, switch marinedate:to ISO (marine_window_begin_iso), rename aero gaussianvariables to output:→variables:, and addfinal_j_evaluation: truefor marine. - Shift the weekly stable-PR cron schedule (primary 10:17→08:17 UTC, fallback 21:37→14:37 UTC) and update the
atm_jjob_3dvar.refreference with the new increment-print output.
| File | Description |
|---|---|
parm/jcb-gdas/model/atmosphere/atmosphere_final_increment_cubed_sphere.yaml.j2 |
Remove output:/state component: wrapper; flat writer config |
parm/jcb-gdas/model/atmosphere/atmosphere_final_increment_fms_nonrestart.yaml.j2 |
Same flattening of writer config |
parm/jcb-gdas/model/atmosphere/atmosphere_final_increment_gaussian.yaml.j2 |
Same flattening of writer config |
parm/jcb-gdas/model/snow/snow_final_increment_fms.yaml.j2 |
Same flattening of writer config |
parm/jcb-gdas/model/soil/soil_final_increment_csg.yaml.j2 |
Same flattening of writer config |
parm/jcb-gdas/model/marine/marine_final_increment.yaml.j2 |
Flatten; switch date to ISO var and add times: list |
parm/jcb-gdas/model/aero/aero_final_increment_cubed_sphere.yaml.j2 |
Flatten; add times: list |
parm/jcb-gdas/model/aero/aero_final_increment_gaussian.yaml.j2 |
Rename variables to output:→variables:; add times: |
parm/marine/jcb-base.yaml.j2 |
Add final_j_evaluation: true |
.github/workflows/weekly-stable-pr.yaml |
Adjust primary/fallback cron times |
test/testreference/atm_jjob_3dvar.ref |
Update reference to include increment-print block |
No high-confidence objective defects were found within the diffed regions. The new template variables are defined in the corresponding jcb-base.yaml.j2 files, the cron comments match their expressions, and the writer flattening is applied consistently across all *_final_increment* templates. The changes are an automated sync of already-CI-validated upstream commits, so their correctness primarily depends on compatibility with the deployed upstream JEDI/fv3-jedi/SOCA version, which cannot be verified from this repository alone.
Review effort: Balanced
|
@CoryMartin-NOAA and @DavidNew-NOAA : GDASApp The After this, I will update the |
|
WCOSS2 GDASApp CI Run GDASApp |
|
Thank you @CoryMartin-NOAA for the review and approval. I'll merge once the Ursa tests completes or we reached 4 pm today, whichever comes first. The Ursa tests are 70% complete with no failures so far. |
CI Run Summary for PR #2312 (Commit: 3a32394)Automated GW-GDASApp Testing Results: CI Status: Passed |
|
GDASApp CI Passed on Ursa and WCOSS2 (Cactus). Merging now. |
Automated weekly PR to sync stable-nightly updates into develop. Triggered on 20261101.
Automated CI tests to run in Global Workflow