Add --discard-non-matching-values to remove non-matching x and scales when exporting into APPLgrid - #400
Conversation
cschwan
left a comment
cschwan
left a comment
There was a problem hiding this comment.
Looks good to me, although we should refactor the code at some point, but probably not here and now.
I wonder whether we should merge the option into a single discard-non-matching-values that enables both. I don't think there's a reason to keep them separate. To make it backwards-compatible, we should add an alias (see also #291).
|
I fully agree! And I just implemented it in 8ba5416. |
Radonirinaunimi
changed the title
discard_non_matching_momentum to remove non-matching x when exporting into APPLgrid--discard-non-matching-values to remove non-matching x and scales when exporting into APPLgrid
cschwan
left a comment
cschwan
left a comment
There was a problem hiding this comment.
Can you extract the problematic subgrid(s)? The remaining subgrids are just dead weight.
|
I am not exactly sure what you mean by this? |
|
In general, we should keep the test-data size as small as possible, also to minimize the test run time. In this case I think we can just isolate the subgrid that's affected by the new flag and throw away the rest. |
|
Commit f928b80 uses a smaller grid, which I created by stripping all log-orders and all bins except bin # 63. This bin has the most 'failing' values, including both factorization-scale and momentum-fraction types; the test grids goes down in size from 175 MB to 216 KB, which saves bandwidth and testing/CI time. |
cschwan
left a comment
cschwan
left a comment
There was a problem hiding this comment.
@Radonirinaunimi: have a look at my changes; as far as I am concerned this can be merged.
|
Sorry @cschwan I was not able to look into it yesterday, so thanks for taking care of it. The changes look perfect to me. |
2 participants
TODO: