Update docstrings in validphys with new datasets names#2490
Update docstrings in validphys with new datasets names#2490kamillaurent wants to merge 6 commits into
Conversation
|
In general, if you are not doing a fit, then the fraction is not needed (since it is the training/validation split) RE legacy, use the variant that is used in the 4.1 runcard. If, for whataver reason, it cannot be used (e.g. it is an example that only runs for older theories and data for some reason) then use legacy. |
|
Regarding datasets that are not in the |
I'd say the closest one. But again, if it is an exmaple, you can choose a different dataset and make sure that the example is showing the same. |
|
Hi @kamillaurent is this complete? |
|
I don't spot any old name in the docstrings, so I believe this is complete @scarlehoff |
1 similar comment
|
I don't spot any old name in the docstrings, so I believe this is complete @scarlehoff |
| ------- | ||
| str or tuple of (str, str) | ||
| The PC type key(s). For the NMC ratio dataset | ||
| The PC type key(s). For the ratio dataset |
There was a problem hiding this comment.
here I think NMC was acting more as a noun referring to the NMC collaboration itself. But it's ok, it reads good either way
| replica 1 | ||
| group dataset id | ||
| ATLAS ATLASZPT8TEVMDIST 1 30.665835 | ||
| ATLAS ATLAS_Z0J_8TEV_PT-M 1 30.665835 |
There was a problem hiding this comment.
Here, instead of changing this manually you should run the code above and update the info (you will see that you cannot use pseudodata_test_fit_n3fit and have to use an updated version such as pseudodata_test_fit_n3fit_260518), which has 15 replicas instead of 10 and which has ATLAS_Z0_7TEV_46FB_CC-Y as first dataset.
| @@ -88,10 +88,10 @@ def experiments_to_dataset_inputs(experiments_list): | |||
| >>> fit = API.fit(fit='NNPDF31_nnlo_as_0118_1000') | |||
There was a problem hiding this comment.
Same here. Instead of updating the results of the code, you should update the fit instead.
A recent one you can use is: nnpdf40-like_t0_sampling, and below instead of experiments which doesn't exist anymore, you need to use dataset_inputs = fit.as_input()['dataset_inputs']
I am still not sure when to add
"variant": "legacy"and"frac": 0.75when switching names.