Skip to content

Fix Rust Releases#556

Open
AkshatRai07 wants to merge 4 commits into
masterfrom
fix/rust-releases
Open

Fix Rust Releases#556
AkshatRai07 wants to merge 4 commits into
masterfrom
fix/rust-releases

Conversation

@AkshatRai07

@AkshatRai07 AkshatRai07 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

This PR is a fix to #555
In this PR we,

  • Fix MacOS linking errors.
  • Remove staticlib generation.
  • Make eko versioning dynamic, hence changing the .whl name.

Copilot AI review requested due to automatic review settings July 22, 2026 11:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Rust C-API build/test setup to address macOS dynamic linking issues and to stop producing a staticlib artifact during releases.

Changes:

  • Configure the C-API crate to build only as a cdylib (no staticlib).
  • Add a macOS-specific post-link step in the C-API test runner to rewrite an absolute dylib install name to use @rpath.
  • Update the local build-capi task command used to generate the C-API distribution.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Updates the build-capi task command for producing the C-API dist.
crates/ekore_capi/tests/run_tests.sh Adds a macOS-specific install-name rewrite to make test binaries find the dylib via @rpath.
crates/ekore_capi/Cargo.toml Removes staticlib from the crate’s crate-type list to stop generating static libraries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
Comment thread crates/ekore_capi/tests/run_tests.sh Outdated
@AkshatRai07

AkshatRai07 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

Doubt: Should Rust, C-API, and Python API tests be run on all OS and Architecture combinations which we will use when publishing?

Suggestion: Please try changing the permission of PYPI_TOKEN, and run the entire Maturin workflow, only then merge this PR. Else we will have to wait for v0.15.6.

@AkshatRai07

AkshatRai07 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

There was one more issue, if you see the artifacts of maturin.yml, the version of eko-rs is 0.0.0. I checked locally and changing the version to be dynamic worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants