Fix Rust Releases#556
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Rust C-API build/test setup to address macOS dynamic linking issues and to stop producing a staticlib artifact during releases.
Changes:
- Configure the C-API crate to build only as a
cdylib(nostaticlib). - Add a macOS-specific post-link step in the C-API test runner to rewrite an absolute dylib install name to use
@rpath. - Update the local
build-capitask command used to generate the C-API distribution.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Updates the build-capi task command for producing the C-API dist. |
| crates/ekore_capi/tests/run_tests.sh | Adds a macOS-specific install-name rewrite to make test binaries find the dylib via @rpath. |
| crates/ekore_capi/Cargo.toml | Removes staticlib from the crate’s crate-type list to stop generating static libraries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Doubt: Should Rust, C-API, and Python API tests be run on all OS and Architecture combinations which we will use when publishing? Suggestion: Please try changing the permission of |
|
There was one more issue, if you see the artifacts of |
This PR is a fix to #555
In this PR we,
staticlibgeneration.ekoversioning dynamic, hence changing the.whlname.