Add ekore_py#554
Conversation
|
Doubt, what should we name this python library? |
There was a problem hiding this comment.
Pull request overview
Adds a new ekore_py crate intended to provide Python bindings for ekore via PyO3, and wires it into the workspace/release metadata while updating crate READMEs to reference the new component.
Changes:
- Introduces a new
crates/ekore_pypackage with an initial PyO3 module scaffold plus Python packaging metadata (pyproject.toml). - Adds
pyo3to workspace dependencies and updatesCargo.lockaccordingly. - Updates framework documentation and release crate list to include
ekore_py.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/release.json | Adds ekore_py to the crate release list. |
| crates/ekore/README.md | Mentions the new ekore_py crate in the framework list. |
| crates/ekore_py/src/lib.rs | Adds initial PyO3 module scaffold (currently a template function). |
| crates/ekore_py/README.md | Introduces README for the Python binding crate. |
| crates/ekore_py/pyproject.toml | Adds maturin-based Python build metadata for ekore_py. |
| crates/ekore_py/Cargo.toml | Adds new Rust crate manifest for the PyO3 cdylib. |
| crates/ekore_capi/README.md | Mentions ekore_py in the framework list. |
| crates/eko/README.md | Mentions ekore_py in the framework list. |
| crates/dekoder/README.md | Mentions ekore_py in the framework list. |
| Cargo.toml | Adds pyo3 to workspace dependencies. |
| Cargo.lock | Updates lockfile format/version and adds PyO3 dependency graph entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I guess there are two options: |
|
The crate name will be |
A step for #519
In this PR we:
ekore_pycrate, which exposesekorecrate usingPyO3and build the lib usingmaturin.TODO