Fieldset incorrectly gets set in error when a child input is in error

It seems like the fieldset component will set itself in error if one of the child inputs inside it is in error. This is not correct - it should only be in error if the fieldset as a whole is in error.

The result is that the left red error bar extends across the entire fieldset, rather than just the field that is in error.

You could possibly say that this is something to be decided on a question by question basis - but then this shouldn't be the default as it's not how the native components work.

It's not in the docs, but reading the package source, I see you can use <Fieldset disableErrorLine="false"> to explicitly disable this.

Incorrect:

Correct:

There's no example of this in the NHS design system, but it's covered in the GOV.UK design system:

@edwardhorsford

@edwardhorsford @rowellx68 Can you see if I've fixed this in #267?

I can see disableErrorLine is no longer present.

Will there be related changelogs / upgrade notes for these things that have been removed / changed? This alone could be a breaking change.

Yeah here's the Upgrading to 6.0 guide from #267

Fieldsets are no longer necessary in the sense that, if a component wants one, it does it itself

- <Fieldset>
-   <Fieldset.Legend>Have you changed your name?</Fieldset.Legend>
-   <Radios>
+   <Radios legend="Have you changed your name?">
-     <Radios.Radio value="yes">Yes</Radios.Radio>
-     <Radios.Radio value="no">No</Radios.Radio>
+     <Radios.Item value="yes">Yes</Radios.Item>
+     <Radios.Item value="no">No</Radios.Item>
    </Radios>
- </Fieldset>

I don't see disableErrorLine being mentioned in the guide - should we mention that it's been removed?

I don't see disableErrorLine being mentioned in the guide - should we mention that it's been removed?

Yeah, for people that forget to remove <Fieldset>?

It's still there on every form component and the ~~<SingleInputFormGroup>~~ <FormGroup> wrapper

Since every component that uses <FormGroup> can set/unset its own error we no longer need disableErrorLine

Confirming it's closed by #267 and the guide has been updated

Navigation Menu

Repository navigation

Fieldset incorrectly gets set in error when a child input is in error #245

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Fieldset incorrectly gets set in error when a child input is in error #245

Description

Activity

colinrotherham commented on Sep 9, 2025

edwardhorsford commented on Sep 10, 2025

colinrotherham commented on Sep 10, 2025

edwardhorsford commented on Sep 10, 2025

colinrotherham commented on Sep 10, 2025

colinrotherham commented on Sep 29, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions