Skip to content

Suggestion: remove all 'boolean' examples from storybook #215

Closed

Description

@edwardhorsford

The storybook includes 'boolean' error examples. Example:
Screenshot 2024-05-01 at 13 04 02

I think all such examples should be removed. They are not part of the design system and should never be used. We would never want to present errors without error messages.

If theres's some reason they exist that I'm not aware, of I would suggest adding annotation to note they are not for regular use.

Activity

  1. colinrotherham commented on Sep 29, 2025

    @colinrotherham
    Collaborator

    This has been fixed in #267


    Make sure error message text is added

    For accessibility reasons and to align with NHS.UK frontend, the boolean error: true prop must be replaced with an error message string:

      <TextInput
        label="What is your NHS number?"
        labelProps={{ isPageHeading: true, size: 'l' }}
    -   error
    +   error="Enter NHS number"
      />

    Read about our guidance on error messages on the design system in the NHS digital service manual.

  2. added this to the v6.0.0 milestone on Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions