Consolidate docker compose services - #240
Merged
Merged
Conversation
Add a modality_emulator profile to optionally start automatic emulation.
1 task
carlosmartinez
approved these changes
Oct 1, 2026
carlosmartinez
left a comment
carlosmartinez
left a comment
Contributor
There was a problem hiding this comment.
seems reasonable!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In deployed environments the gateway runs a bunch of python processes as services on the same machine/VM.
Our current docker setup creates a container per service, this doesn't represent the real world gateway composition.
This PR consolidates the gateway services into one container.
Adds a profile to optionally run automatic modality emulation in a separate container.
Documents the vagaries of networking on different OS's.
Jira link
Precursor to smoke test script https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12894
Review notes
Review checklist