Fix hard coded token limit - #859
Merged
Merged
Conversation
MarkDWilliams
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working on tuning task concurrency and retry functionality. The default value for the ARS_EXPENSIVE_LIMIT env var, which controls the number of available tokens for concurrent tasks, was recently increased from 6 to 12, which is good, but in tr_sys/tr_ara/utils.py a call to expensive_section() still hard coded this limit to 6, ignoring the value set by the env var.
This PR removes that hardcoded value and renames the previous python constant used for this setting "DEFAULT_LIMIT" to a more explicit "ARS_EXPENSIVE_TOKEN_LIMIT". This still doesn't match the env var, which might be nice, but keeping the env var the same avoids breaking configs external to this repo (ie jenkins).