Switch production deployment to gunicorn - #855
Merged
Merged
Conversation
chevvak2
approved these changes
Jun 18, 2026
MarkDWilliams
approved these changes
Jun 23, 2026
MarkDWilliams
left a comment
Collaborator
There was a problem hiding this comment.
Trying this out and then we can test in CI to see if how it affects performance.
Contributor
Author
|
The other thing we might want to look at here is the worker type - https://gunicorn.org/design/#worker-types gthread is used in this PR because it is the most compatible with the widest variety of other python libraries (least likely to break things in weird ways) but it is entirely possible (even likely) that gevent workers would give us better performance for scaling up more concurrent requests with limited hardware. Either should be an improvement over the Django server though, so we shouldn't let this consideration stop us from deploying with gthread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless there is another helm chart living somewhere else, we're running Django's development server (manage.py runserver) in production. That is not recommended by Django and can cause serious performance issues:
Switching to gunicorn with workers solves a lot of those issues:
If we adopt this, we'll want to add the new gunicorn values to our ncats-values files, and it's strongly recommended to tune the number of workers according to the amount of CPU we have allocated. Comments in the chart show where/how to do that.
Along with this, it is highly recommended that we double check the settings not committed to this repo (deploy/configs/settings.py) and make sure Django is not being run in DEBUG mode for CI, test, or prod, and probably we don't need DJANGO_LOG_LEVEL=DEBUG there either. It might be nice to use environment variables configurable from helm values for these to make it easy to set them per-maturity-level.